How To Put Your Post In Sequence Instagram

@@ -239,7 +239,13 @@ def connection_made(self, transport):
  self._over_ssl = transport.get_extra_info('sslcontext') is not None
  if self._client_connected_cb is not None:
  writer = StreamWriter(transport, self, reader, self._loop)
- res = self._client_connected_cb(reader, writer)
+ try:
+ res = self._client_connected_cb(reader, writer)
+ except BaseException:
+ transport.close()
+ raise
+ finally:
+ self._strong_reader = None
  if coroutines.iscoroutine(res):
  def callback(task):
  if task.cancelled():
@@ -257,8 +263,6 @@ def callback(task):
  self._task = self._loop.create_task(res)
  self._task.add_done_callback(callback)
 
- self._strong_reader = None
-
  def connection_lost(self, exc):
  reader = self._stream_reader
  if reader is not None:

Overnight Prints Business Cards

@@ -889,6 +889,22 @@ def test_streamwriter_start_tls_updates_reader_transport(self):
  self.assertIs(reader._transport, new_transport)
  self.assertTrue(protocol._over_ssl)
 
+ def test_sync_client_cb_closes_transport_on_error(self):
+ reader = asyncio.StreamReader(loop=self.loop)
+
+ def client_connected_cb(reader, writer):
+ raise RuntimeError('test')
+
+ protocol = asyncio.StreamReaderProtocol(
+ reader, client_connected_cb, loop=self.loop)
+ transport = mock.Mock()
+ transport.get_extra_info.return_value = None
+
+ with self.assertRaisesRegex(RuntimeError, 'test'):
+ protocol.connection_made(transport)
+
+ transport.close.assert_called_once_with()
+
  def test_streamreader_constructor_without_loop(self):
  with self.assertRaisesRegex(RuntimeError, 'no current event loop'):
  asyncio.StreamReader()

Story Writing Outline Template

@@ -0,0 +1,3 @@
+Close the transport when a synchronous callback passed to
+:func:`asyncio.start_server` or :func:`asyncio.start_unix_server` raises an
+exception.