fix: correctly handle null responses from requests

Author: Great Blog Post Examples

plugin/platforms/android/java/com/nativescript/https/OkHttpResponse.java

@@ -53,6 +53,9 @@ public OkHttpResponse(ResponseBody body) {
  public void cancel() {
  cancelled = true;
  }
+ public long contentLength() {
+ return responseBody.contentLength();
+ }
 
  static void runProgressCallback(final OkHttpResponseProgressCallback progressCallback, final long current,
  final long total) {
@@ -151,6 +154,7 @@ private static void closeResponseBody(ResponseBody responseBody, OkHttpResponseC
 
  static Bitmap responseBodyToBitmap(OkHttpResponse response, OkHttpResponseProgressCallback progressCallback)
  throws Exception {
+ 
  BufferedInputStream input = null;
  OutputStream output = null;
  try {
@@ -297,6 +301,7 @@ public void run() {
  }
 
  static java.nio.ByteBuffer responseBodyToByteArray(OkHttpResponse response) throws IOException {
+ 
  final byte[] result = response.responseBody.bytes();
  response.closeResponseBody();
  return java.nio.ByteBuffer.wrap(result);
@@ -347,6 +352,7 @@ public void run() {
  }
 
  static String responseBodyToString(OkHttpResponse response) throws IOException {
+ 
  final String responseString = response.responseBody.string();
  response.closeResponseBody();
  return responseString;

src/https.android.ts

@@ -122,12 +122,12 @@ class HttpsResponse implements Https.HttpsResponseLegacy {
  jsonResponse: any;
  toJSON(encoding?: HttpResponseEncoding) {
  try {
- if (this.jsonResponse) {
+ if (this.jsonResponse !== undefined) {
  return this.jsonResponse;
  }
  // TODO: handle arraybuffer already stored
  this.stringResponse = this.stringResponse || this.response.asString();
- this.jsonResponse = Https.parseJSON(this.stringResponse);
+ this.jsonResponse = this.stringResponse ? Https.parseJSON(this.stringResponse) : null;
  return this.jsonResponse;
  } catch (err) {
  console.error('HttpsResponse.toJSON', err);
@@ -136,16 +136,16 @@ class HttpsResponse implements Https.HttpsResponseLegacy {
  }
 
  async toJSONAsync() {
- if (this.jsonResponse) {
+ if (this.jsonResponse !== undefined) {
  return this.jsonResponse;
  }
- if (this.stringResponse) {
- this.jsonResponse = Https.parseJSON(this.stringResponse);
+ if (this.stringResponse !== undefined) {
+ this.jsonResponse = this.stringResponse ? Https.parseJSON(this.stringResponse) : null;
  return this.jsonResponse;
  }
  // TODO: handle arraybuffer already stored
  const r = await this.toStringAsync();
- this.jsonResponse = Https.parseJSON(r);
+ this.jsonResponse = r ? Https.parseJSON(r) : null;
  return this.jsonResponse;
  }