test: increase Linux test coverate

Some tests (`test/addon/jsapi-test.js` and `test/plugin/scan-test.js`) were not running on Linux because LLDB is not able to save core dumps on that platform. These changes use a simpler approach to save core dumps on Linux so these tests can also be run there. Ref: Most Popular Products XXL People PR-URL: Unsecured Credit Cards For People With Bad Credit Refs: Product Survey Template Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Author: Matheus Marchini

test/addon/jsapi-test.js

@@ -15,9 +15,6 @@ tape('llnode API', (t) => {
  if (process.env.LLNODE_CORE && process.env.LLNODE_NODE_EXE) {
  test(process.env.LLNODE_NODE_EXE, process.env.LLNODE_CORE, t);
  t.end();
- } else if (process.platform === 'linux') {
- t.skip('No `process save-core` on linux');
- t.end();
  } else {
  common.saveCore({
  scenario: 'inspect-scenario.js'

test/common.js

@@ -98,7 +98,8 @@ SessionOutput.prototype.wait = function wait(regexp, callback, allLines) {
 
  function onLine(line) {
  lines.push(line);
- debug(`[LINE][${self.session.lldb.pid}]`, line);
+ if (self.session)
+ debug(`[LINE][${self.session.lldb.pid}]`, line);
 
  if (!regexp.test(line))
  return;
@@ -205,10 +206,7 @@ Session.create = function create(scenario) {
  return new Session({ scenario: scenario });
 };
 
-exports.saveCore = function saveCore(options, cb) {
- const scenario = options.scenario;
- const core = options.core || exports.core;
-
+function saveCoreLLDB(scenario, core, cb) {
  // Create a core and test
  const sess = Session.create(scenario);
  sess.timeoutAfter(exports.saveCoreTimeout);
@@ -234,6 +232,47 @@ exports.saveCore = function saveCore(options, cb) {
  });
 }
 
+function spawnWithTimeout(cmd, cb) {
+ const proc = spawn(cmd, {
+ shell: true,
+ stdio: ['pipe', 'pipe', 'pipe'] });
+ const stdout = new SessionOutput(null, proc.stdout, exports.saveCoreTimeout);
+ const stderr = new SessionOutput(null, proc.stderr, exports.saveCoreTimeout);
+ stdout.on('line', (line) => { debug('[stdout]', line); });
+ stderr.on('line', (line) => { debug('[stderr]', line); });
+
+ const timeout = setTimeout(() => {
+ console.error(`timeout while saving core dump for scenario "${scenario}"`);
+ proc.kill();
+ }, exports.saveCoreTimeout);
+
+ proc.on('exit', (status) => {
+ clearTimeout(timeout);
+ cb(null);
+ });
+}
+
+function saveCoreLinux(executable, scenario, core, cb) {
+ const cmd = `ulimit -c unlimited && ${executable} ` +
+ `--abort_on_uncaught_exception --expose_externalize_string ` +
+ `${path.join(exports.fixturesDir, scenario)}; `;
+ spawnWithTimeout(cmd, () => {
+ // FIXME (mmarchini): Should also handle different core system settings.
+ spawnWithTimeout(`mv ./core ${core}`, cb);
+ });
+}
+
+exports.saveCore = function saveCore(options, cb) {
+ const scenario = options.scenario;
+ const core = options.core || exports.core;
+
+ if (process.platform === 'linux') {
+ saveCoreLinux(process.execPath, scenario, core, cb);
+ } else {
+ saveCoreLLDB(scenario, core, cb);
+ }
+}
+
 // Load the core dump with the executable
 Session.loadCore = function loadCore(executable, core, cb) {
  const ranges = process.env.LLNODE_NO_RANGES ? undefined : core + '.ranges';

test/plugin/scan-test.js

@@ -10,9 +10,6 @@ tape('v8 findrefs and friends', (t) => {
  // Use prepared core and executable to test
  if (process.env.LLNODE_CORE && process.env.LLNODE_NODE_EXE) {
  test(process.env.LLNODE_NODE_EXE, process.env.LLNODE_CORE, t);
- } else if (process.platform === 'linux') {
- t.skip('No `process save-core` on linux');
- t.end();
  } else {
  common.saveCore({
  scenario: 'inspect-scenario.js'