Enable and disable GIT_OPT_ENABLE_STRICT_OBJECT_CREATION only were necessary

Author: Personal Blog Writing

ObjectiveGit/GTTreeBuilder.m

@@ -137,7 +137,6 @@ - (GTTreeEntry *)addEntryWithOID:(GTOID *)oid fileName:(NSString *)fileName file
  NSParameterAssert(fileName != nil);
 
  const git_tree_entry *entry = NULL;
- git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 0);
  int status = git_treebuilder_insert(&entry, self.git_treebuilder, fileName.UTF8String, oid.git_oid, (git_filemode_t)fileMode);
 
  if (status != GIT_OK) {

ObjectiveGitTests/GTRepositoryCommittingSpec.m

@@ -27,6 +27,7 @@
 });
 
 it(@"can create commits", ^{
+ git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 0);
  GTTreeBuilder *builder = [[GTTreeBuilder alloc] initWithTree:nil repository:repository error:NULL];
  expect(builder).notTo(beNil());
 
@@ -53,6 +54,7 @@
  GTReference *ref = [repository headReferenceWithError:NULL];
  expect(ref).notTo(beNil());
  expect(ref.resolvedTarget).to(equal(initialCommit));
+ git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 1);
 });
 
 afterEach(^{

ObjectiveGitTests/GTTreeBuilderSpec.m

@@ -104,7 +104,9 @@
  });
 
  it(@"should write new blobs when the tree is written", ^{
+ git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 0);
  GTTreeEntry *entry = [builder addEntryWithData:[@"Hello, World!" dataUsingEncoding:NSUTF8StringEncoding] fileName:@"test.txt" fileMode:GTFileModeBlob error:NULL];
+ git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 1);
  expect(entry).notTo(beNil());
 
  GTObjectDatabase *database = [repo objectDatabaseWithError:NULL];

ObjectiveGitTests/GTUtilityFunctions.m

@@ -19,8 +19,10 @@
  GTBranch *branch = [GTBranch branchWithReference:head repository:repo];
  GTCommit *headCommit = [branch targetCommitWithError:NULL];
 
+ git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 0);
  GTTreeBuilder *treeBuilder = [[GTTreeBuilder alloc] initWithTree:headCommit.tree repository:repo error:nil];
  [treeBuilder addEntryWithData:fileData fileName:fileName fileMode:GTFileModeBlob error:nil];
+ git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 1);
 
  GTTree *testTree = [treeBuilder writeTree:nil];