Cover malformed successful query responses

Author: How To Make Blog Post In WordPress

src/vws/async_query.py

@@ -122,6 +122,8 @@ async def query(
  error with Vuforia's servers.
  ~vws.exceptions.base_exceptions.CloudRecoError: Vuforia returned
  a client error without a recognized JSON body.
+ json.JSONDecodeError: Vuforia returned a successful response with
+ an invalid JSON body.
 
  Returns:
  An ordered list of target details of matching

src/vws/query.py

@@ -104,6 +104,8 @@ def query(
  error with Vuforia's servers.
  ~vws.exceptions.base_exceptions.CloudRecoError: Vuforia returned
  a client error without a recognized JSON body.
+ json.JSONDecodeError: Vuforia returned a successful response with
+ an invalid JSON body.
 
  Returns:
  An ordered list of target details of matching targets.

tests/test_async_cloud_reco_exceptions.py

@@ -3,6 +3,7 @@
 """
 
 import io # noqa: TC003
+import json
 import uuid
 from http import HTTPStatus
 
@@ -168,3 +169,26 @@ async def test_non_json_client_error(
  }
  assert response_headers["x-query-failure"] == headers["X-Query-Failure"]
  assert response.request_body
+
+
+@pytest.mark.asyncio
+async def test_non_json_success_response(
+ *,
+ high_quality_image: io.BytesIO,
+) -> None:
+ """Malformed successful responses retain the JSON parsing error."""
+ database = CloudDatabase()
+ failure_response = CloudQueryFailureResponse(
+ status_code=HTTPStatus.OK,
+ headers={"Content-Type": "application/json"},
+ body="Not JSON",
+ )
+ cloud_reco_client = AsyncCloudRecoService(
+ client_access_key=database.client_access_key,
+ client_secret_key=database.client_secret_key,
+ )
+
+ with MockVWS(cloud_query_failure_response=failure_response) as mock:
+ mock.add_cloud_database(cloud_database=database)
+ with pytest.raises(expected_exception=json.JSONDecodeError):
+ await cloud_reco_client.query(image=high_quality_image)

tests/test_cloud_reco_exceptions.py

@@ -1,6 +1,7 @@
 """Tests for exceptions raised when using the CloudRecoService."""
 
 import io # noqa: TC003
+import json
 import uuid
 from http import HTTPStatus
 
@@ -174,3 +175,25 @@ def test_non_json_client_error(
  }
  assert response_headers["x-query-failure"] == headers["X-Query-Failure"]
  assert response.request_body
+
+
+def test_non_json_success_response(
+ *,
+ high_quality_image: io.BytesIO,
+) -> None:
+ """Malformed successful responses retain the JSON parsing error."""
+ database = CloudDatabase()
+ failure_response = CloudQueryFailureResponse(
+ status_code=HTTPStatus.OK,
+ headers={"Content-Type": "application/json"},
+ body="Not JSON",
+ )
+ cloud_reco_client = CloudRecoService(
+ client_access_key=database.client_access_key,
+ client_secret_key=database.client_secret_key,
+ )
+
+ with MockVWS(cloud_query_failure_response=failure_response) as mock:
+ mock.add_cloud_database(cloud_database=database)
+ with pytest.raises(expected_exception=json.JSONDecodeError):
+ cloud_reco_client.query(image=high_quality_image)